Adding Image Comparison#1345
Draft
jtreminio wants to merge 5 commits intomcmonkeyprojects:masterfrom
Draft
Conversation
Member
|
As stated on Discord: multi-selection logic should be native to Browser.js, and fully separately completed before the image compare thing |
jtreminio
force-pushed
the
multi-select-image-comparison
branch
from
7a94875 to
22e778f
Compare
jtreminio
changed the title
Contributor
Author
|
Depends on #1360 - once that is merged I'll rebase so this diff will become smaller. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is under active development. As stated in the Discord, the following changes remain:
simplify
MultiSelectToolchange the multi-select UI to native browser multi-select
This is a lot of code. The CSS and most of the JS came from another project I was working on before thinking this would probably fit in well in SwarmUI.
I needed AI assistance for the CSS portion. There was no way I was going to figure that out for myself.
I needed AI assistance for the maths in the JS. The rest of it is mine, including all bugs.
I've tried to reuse as much code as possible from
ImageFullViewHelperfor the newImageCompareHelper. There are parts of it that are not really needed, I will be going through and cleaning up as much as needed without diverging too much from the original.CleanShot.2026-04-13.at.22.32.42.mp4
CleanShot.2026-04-13.at.22.34.53.mp4